Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
M
Material
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Dmitriy Stepanets
Material
Commits
6b989a48
Unverified
Commit
6b989a48
authored
Jun 29, 2018
by
Daniel Dahan
Committed by
GitHub
Jun 29, 2018
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1107 from OrkhanAlikhanov/no-will-set
Removed `willSet`s
parents
004e64c2
2cc73a7b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
14 deletions
+5
-14
Sources/iOS/TabBar.swift
+1
-3
Sources/iOS/TransitionController.swift
+4
-11
No files found.
Sources/iOS/TabBar.swift
View file @
6b989a48
...
@@ -249,10 +249,8 @@ open class TabBar: Bar {
...
@@ -249,10 +249,8 @@ open class TabBar: Bar {
/// The currently selected tabItem.
/// The currently selected tabItem.
open
internal(set)
var
selectedTabItem
:
TabItem
?
{
open
internal(set)
var
selectedTabItem
:
TabItem
?
{
willSet
{
selectedTabItem
?
.
isSelected
=
false
}
didSet
{
didSet
{
oldValue
?
.
isSelected
=
false
selectedTabItem
?
.
isSelected
=
true
selectedTabItem
?
.
isSelected
=
true
}
}
}
}
...
...
Sources/iOS/TransitionController.swift
View file @
6b989a48
...
@@ -57,22 +57,15 @@ open class TransitionController: UIViewController {
...
@@ -57,22 +57,15 @@ open class TransitionController: UIViewController {
helper method.
helper method.
*/
*/
open
internal(set)
var
rootViewController
:
UIViewController
!
{
open
internal(set)
var
rootViewController
:
UIViewController
!
{
willSet
{
guard
newValue
!=
rootViewController
else
{
return
}
guard
let
v
=
rootViewController
else
{
return
}
removeViewController
(
viewController
:
v
)
}
didSet
{
didSet
{
guard
oldValue
!=
rootViewController
else
{
guard
oldValue
!=
rootViewController
else
{
return
return
}
}
if
let
v
=
oldValue
{
removeViewController
(
viewController
:
v
)
}
prepare
(
viewController
:
rootViewController
,
in
:
container
)
prepare
(
viewController
:
rootViewController
,
in
:
container
)
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment