Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
1
1weather
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Dmitriy Stepanets
1weather
Commits
dc0d546b
Commit
dc0d546b
authored
Jun 10, 2021
by
Demid Merzlyakov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
IOS-106: Remove unused code, fix analytics for native ads.
parent
387d5c72
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
36 deletions
+3
-36
1Weather/Ads/Configuration/AdConfig.swift
+1
-31
1Weather/Ads/Native/NativeAdItem.swift
+2
-5
No files found.
1Weather/Ads/Configuration/AdConfig.swift
View file @
dc0d546b
...
...
@@ -16,16 +16,11 @@ public struct AdConfig: Codable {
var
a9MaxCachedPerPlacement
:
UInt
var
placements
:
[
AdPlacementName
:
AdPlacement
]?
var
nativePlacements
:
[
AdPlacementName
:
NativeAdPlacement
]?
func
placement
(
named
name
:
String
)
->
AdPlacement
?
{
return
placements
?[
name
]
}
func
nativePlacement
(
named
name
:
String
)
->
NativeAdPlacement
?
{
return
nativePlacements
?[
name
]
}
struct
CodingKeys
:
CodingKey
{
var
stringValue
:
String
init
(
stringValue
:
String
)
{
...
...
@@ -89,8 +84,7 @@ extension AdConfig: Equatable {
public
static
func
==
(
lhs
:
AdConfig
,
rhs
:
AdConfig
)
->
Bool
{
return
lhs
.
adsEnabled
==
rhs
.
adsEnabled
&&
lhs
.
a9RefreshRate
==
rhs
.
a9RefreshRate
&&
lhs
.
placements
==
rhs
.
placements
&&
lhs
.
nativePlacements
==
rhs
.
nativePlacements
lhs
.
placements
==
rhs
.
placements
}
}
...
...
@@ -104,21 +98,6 @@ extension ContentUrlConfig: Equatable {
}
}
struct
NativeAdPlacement
:
Codable
{
var
name
:
String
var
adUnitId
:
String
var
refreshInterval
:
TimeInterval
var
interstitialScreenCount
:
Int
?
enum
CodingKeys
:
String
,
CodingKey
{
case
name
case
adUnitId
=
"ad_unit_id"
case
refreshInterval
=
"refresh_interval"
case
interstitialScreenCount
=
"interstitial_screen_count"
}
}
struct
AdPlacement
:
Codable
{
var
name
:
String
var
adUnitId
:
String
...
...
@@ -143,12 +122,3 @@ extension AdPlacement: Equatable {
lhs
.
refreshInterval
==
rhs
.
refreshInterval
}
}
extension
NativeAdPlacement
:
Equatable
{
static
func
==
(
lhs
:
NativeAdPlacement
,
rhs
:
NativeAdPlacement
)
->
Bool
{
return
lhs
.
name
==
rhs
.
name
&&
lhs
.
adUnitId
==
rhs
.
adUnitId
&&
lhs
.
refreshInterval
==
rhs
.
refreshInterval
&&
lhs
.
interstitialScreenCount
==
rhs
.
interstitialScreenCount
}
}
1Weather/Ads/Native/NativeAdItem.swift
View file @
dc0d546b
...
...
@@ -18,8 +18,8 @@ final class NativeAdItem: NSObject {
case
banner
}
private
var
placement
:
Native
AdPlacement
?
{
return
AdConfigManager
.
shared
.
adConfig
.
nativeP
lacements
?
.
filter
({
$0
.
value
.
adUnitId
==
adUnitId
})
.
first
?
.
value
private
var
placement
:
AdPlacement
?
{
return
AdConfigManager
.
shared
.
adConfig
.
p
lacements
?
.
filter
({
$0
.
value
.
adUnitId
==
adUnitId
})
.
first
?
.
value
}
private
var
analyticsParams
:
[
AnalyticsParameter
:
Any
]
{
...
...
@@ -60,9 +60,6 @@ final class NativeAdItem: NSObject {
}
func
placementName
()
->
AdPlacementName
?
{
if
let
nativePlacement
=
AdConfigManager
.
shared
.
adConfig
.
nativePlacements
?
.
filter
({
$0
.
value
.
adUnitId
==
adUnitId
})
.
first
{
return
nativePlacement
.
key
}
if
let
bannerPlacement
=
AdConfigManager
.
shared
.
adConfig
.
placements
?
.
filter
({
$0
.
value
.
adUnitId
==
adUnitId
})
.
first
{
return
bannerPlacement
.
key
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment